Repository navigation
fix(cli): exit non-zero when concore build --auto-build fails - #673
Open
yadavchiragg wants to merge 1 commit into
Open
yadavchiragg wants to merge 1 commit into
yadavchiragg wants to merge 1 commit into
Conversation
|
🎉 Welcome aboard, @yadavchiragg! Thank you for your first pull request in concore. Please ensure that you are contributing to the dev branch. Your contribution means a lot to us. We'll review it shortly. Please ensure you have reviewed our: If you have any questions, feel free to ask. Happy coding! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #640
Problem: when the generated build script failed under --auto-build, concore build printed “Build failed” and then “Workflow ready!” and exited 0, so scripts and CI treated a broken build as a success.
Change: the failure now prints the build output and raises, so the CLI’s existing error handler prints the error and exits 1. The “Workflow ready” panel is no longer shown after a failure. Successful builds and builds without --auto-build behave as before.
Testing: new tests/test_build_failure.py covers a failing build (non-zero exit, output shown, no “Workflow ready”), a successful build, and no --auto-build. The failing-build test fails on current dev and passes with this change. ruff format --check, ruff check and the full suite pass.